hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11586) ObjectInspectorFactory.getReflectionObjectInspector is not thread-safe
Date Wed, 19 Aug 2015 12:16:45 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702924#comment-14702924
] 

Hive QA commented on HIVE-11586:
--------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12751131/HIVE-11586.2.patch

{color:green}SUCCESS:{color} +1 9371 tests passed

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5008/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5008/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5008/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12751131 - PreCommit-HIVE-TRUNK-Build

> ObjectInspectorFactory.getReflectionObjectInspector is not thread-safe
> ----------------------------------------------------------------------
>
>                 Key: HIVE-11586
>                 URL: https://issues.apache.org/jira/browse/HIVE-11586
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: HIVE-11586.1.patch, HIVE-11586.2.patch
>
>
> ObjectInspectorFactory#getReflectionObjectInspectorNoCache addes newly create object
inspector to the cache before calling its init() method, to allow reusing the cache when dealing
with recursive types. So a second thread can then call getReflectionObjectInspector and fetch
an uninitialized instance of ReflectionStructObjectInspector.
> Another issue is that if two threads calls ObjectInspectorFactory.getReflectionObjectInspector
at the same time. One thread could get an object inspector not in the cache, i.e. they could
both call getReflectionObjectInspectorNoCache() but only one will put the new object inspector
to cache successfully.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message