Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0053187A0 for ; Thu, 16 Jul 2015 23:58:04 +0000 (UTC) Received: (qmail 78978 invoked by uid 500); 16 Jul 2015 23:58:04 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 78951 invoked by uid 500); 16 Jul 2015 23:58:04 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 78941 invoked by uid 99); 16 Jul 2015 23:58:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jul 2015 23:58:04 +0000 Date: Thu, 16 Jul 2015 23:58:04 +0000 (UTC) From: "Eugene Koifman (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630562#comment-14630562 ] Eugene Koifman commented on HIVE-11281: --------------------------------------- UpdateDeleteSemanticAnalyzer does mutate AST. There may be others, but even if we currently didn't modify AST this change could created very subtle bugs (especially when trying to debug something based on logs) > Memoize toStringTree() for ASTNode > ---------------------------------- > > Key: HIVE-11281 > URL: https://issues.apache.org/jira/browse/HIVE-11281 > Project: Hive > Issue Type: Bug > Components: Query Planning > Affects Versions: 1.0.0, 1.2.0, 1.1.0 > Reporter: Ashutosh Chauhan > Assignee: Ashutosh Chauhan > Attachments: HIVE-11281.2.patch, HIVE-11281.3.patch, HIVE-11281.patch > > > Currently it defaults to BaseTree::toStringTree() which always computes it recursively. For very large trees it becomes expensive. On one particular test query compilation time went down from 55 seconds to 2 seconds. -- This message was sent by Atlassian JIRA (v6.3.4#6332)