Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53FAE18FF7 for ; Thu, 30 Jul 2015 16:52:05 +0000 (UTC) Received: (qmail 37907 invoked by uid 500); 30 Jul 2015 16:52:05 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 37885 invoked by uid 500); 30 Jul 2015 16:52:05 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 37875 invoked by uid 99); 30 Jul 2015 16:52:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jul 2015 16:52:05 +0000 Date: Thu, 30 Jul 2015 16:52:05 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: ------------------------- Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(event); {code} The return value should be checked. If false is returned, event would not have been queued. Take a look at line 328 in: http://fuseyism.com/classpath/doc/java/util/concurrent/LinkedBlockingQueue-source.html was: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(event); {code} The return value should be checked. If false is returned, event would not have been queued. Take a look at line 328 in: http://fuseyism.com/classpath/doc/java/util/concurrent/LinkedBlockingQueue-source.html > Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner > -------------------------------------------------------------------------------- > > Key: HIVE-8343 > URL: https://issues.apache.org/jira/browse/HIVE-8343 > Project: Hive > Issue Type: Bug > Reporter: Ted Yu > Assignee: JongWon Park > Priority: Minor > Attachments: HIVE-8343.patch > > > In addEvent() and processVertex(), there is call such as the following: > {code} > queue.offer(event); > {code} > The return value should be checked. If false is returned, event would not have been queued. > Take a look at line 328 in: > http://fuseyism.com/classpath/doc/java/util/concurrent/LinkedBlockingQueue-source.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)