hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesus Camacho Rodriguez (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11316) Use datastructure that doesnt duplicate any part of string for ASTNode::toStringTree()
Date Wed, 22 Jul 2015 13:52:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636933#comment-14636933
] 

Jesus Camacho Rodriguez commented on HIVE-11316:
------------------------------------------------

[~hsubramaniyan], I think [~ekoifman] original proposal was slightly different. Could we add
a method to force the recalculation of the memoized String e.g. somebody may call it if the
AST tree mutates, and add a comment to the method about it? Thus, we could have a method toMemoizedStringTree(boolean
refresh) that only (re)computes the memoized String if 1) it has not been already calculated,
or 2) if the refresh flag is true. In turn, the method toStringTree(boolean useMemoization)
could go away. What do you think?

> Use datastructure that doesnt duplicate any part of string for ASTNode::toStringTree()
> --------------------------------------------------------------------------------------
>
>                 Key: HIVE-11316
>                 URL: https://issues.apache.org/jira/browse/HIVE-11316
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-11316-branch-1.0.patch, HIVE-11316-branch-1.2.patch, HIVE-11316.1.patch,
HIVE-11316.2.patch, HIVE-11316.3.patch
>
>
> HIVE-11281 uses an approach to memoize toStringTree() for ASTNode. This jira is suppose
to alter the string memoization to use a different data structure that doesn't duplicate any
part of the string so that we do not run into OOM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message