hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koifman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode
Date Thu, 16 Jul 2015 23:58:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630562#comment-14630562
] 

Eugene Koifman commented on HIVE-11281:
---------------------------------------

UpdateDeleteSemanticAnalyzer does mutate AST.  There may be others, but even if we currently
didn't modify AST this change could created very subtle bugs (especially when trying to debug
something based on logs)

> Memoize toStringTree() for ASTNode
> ----------------------------------
>
>                 Key: HIVE-11281
>                 URL: https://issues.apache.org/jira/browse/HIVE-11281
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Planning
>    Affects Versions: 1.0.0, 1.2.0, 1.1.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: HIVE-11281.2.patch, HIVE-11281.3.patch, HIVE-11281.patch
>
>
> Currently it defaults to BaseTree::toStringTree() which always computes it recursively.
For very large trees it becomes expensive. On one particular test query compilation time went
down from 55 seconds to 2 seconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message