hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ferdinand Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11244) Beeline prompt info improvement for cluster mode
Date Fri, 17 Jul 2015 01:54:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630664#comment-14630664
] 

Ferdinand Xu commented on HIVE-11244:
-------------------------------------

Could you take a look at the failed test case "org.apache.hive.jdbc.TestJdbcWithLocalClusterSpark.testTempTable"?
Also some minor issues about code style, you can refer the wiki for details. https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConventions
{noformat}
1236	      return getPrompt(getDatabaseConnections().getIndex()	1238	      return getPrompt(getDatabaseConnections().getIndex()
1237	          + ": " + getDatabaseConnection().getUrl()) + printClosed + "> ";	1239	 
        + ": " + url) + printClosed + "> ";
{noformat}
No need for breaking line.
{noformat}
		181	\  --showConnectedUrl=[true/false] prompt HiveServer2's IP to which this beeline connected.Only
works for HiveServer2 cluster mode.\n \
{noformat}
Extra space needed after the first sentence and IP should be URI.

> Beeline prompt info improvement for cluster mode
> ------------------------------------------------
>
>                 Key: HIVE-11244
>                 URL: https://issues.apache.org/jira/browse/HIVE-11244
>             Project: Hive
>          Issue Type: Improvement
>          Components: Beeline
>    Affects Versions: 1.2.0
>            Reporter: Nemon Lou
>            Assignee: Nemon Lou
>            Priority: Minor
>              Labels: TODOC2.0
>         Attachments: HIVE-11244.1.patch, HIVE-11244.patch, HIVE-11244.patch, HIVE-11244.patch
>
>
> Currently Beeline prompt info for Cluster mode is like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002,192.168.1>
> {noformat}
> Using the very HiveServer2's IP that this beeline connect to is more helpful for users.
> Like this:
> {noformat}
> 0: jdbc:hive2://192.168.115.1:24002>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message