hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11230) IMetaStoreClient getPartition method arguments incorrectly named
Date Sat, 11 Jul 2015 20:21:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623560#comment-14623560
] 

Hive QA commented on HIVE-11230:
--------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12744869/HIVE-11230.1.patch

{color:green}SUCCESS:{color} +1 9150 tests passed

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4592/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4592/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4592/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12744869 - PreCommit-HIVE-TRUNK-Build

> IMetaStoreClient getPartition method arguments incorrectly named
> ----------------------------------------------------------------
>
>                 Key: HIVE-11230
>                 URL: https://issues.apache.org/jira/browse/HIVE-11230
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Elliot West
>            Assignee: Elliot West
>            Priority: Minor
>              Labels: metastore
>         Attachments: HIVE-11230.1.patch
>
>
> The interface {{org.apache.hadoop.hive.metastore.IMetaStoreClient}} declares a method
{{getPartition}} as:
> {code}
> Partition getPartition(String tblName, String dbName, List<String> partVals) throws
NoSuchObjectException, MetaException, TException;
> {code}
> This is implemented in {{org.apache.hadoop.hive.metastore.HiveMetaStoreClient}} as:
> {code}
> public Partition getPartition(String db_name, String tbl_name, List<String> part_vals)
throws NoSuchObjectException, MetaException, TException {
>   return deepCopy(filterHook.filterPartition(client.get_partition(db_name, tbl_name,
part_vals)));
> }
> {code}
> Note that in the above code the param named {{db_name}} occupies the {{tbl_name}} equivalent
in the {{IMetaStoreClient}} method and vice-versa.
> The method called in {{HiveMetaStoreClient}} also seemingly expects {{db_name}} to appear
first (see {{ThriftHiveMetastore.Iface.get_partition}}):
> {code}
> public Partition get_partition(String db_name, String tbl_name, List<String> part_vals)
throws MetaException, NoSuchObjectException, org.apache.thrift.TException;
> {code}
> And following this all the way through to the implementation of {{org.apache.hadoop.hive.metastore.ObjectStore.getMTable(String,
String)}} shows that the database name is ultimately taken from the first argument.
> Therefore I propose that the order needs to be corrected on {{IMetaStoreClient}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message