hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongzhi Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11136) Unused Logger in org.apache.hadoop.hive.ql.udf.generic.GenericUDAFCount
Date Tue, 14 Jul 2015 19:52:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626952#comment-14626952
] 

Yongzhi Chen commented on HIVE-11136:
-------------------------------------

[~szehon], [~csun], could you review the code? Thanks

> Unused Logger in org.apache.hadoop.hive.ql.udf.generic.GenericUDAFCount
> -----------------------------------------------------------------------
>
>                 Key: HIVE-11136
>                 URL: https://issues.apache.org/jira/browse/HIVE-11136
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Nishant Kelkar
>            Assignee: Yongzhi Chen
>            Priority: Trivial
>         Attachments: HIVE-11136.1.patch
>
>
> There is an unused logger in the GenericUDAFCount. We could either try/catch all the
code that throws exceptions and log them, or get rid of the logger.
> Relevant section of code:
> {code}
> public class GenericUDAFCount implements GenericUDAFResolver2 {
>   private static final Log LOG = LogFactory.getLog(GenericUDAFCount.class.getName());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message