hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11130) Refactoring the code so that HiveTxnManager interface will support lock/unlock table/database object
Date Mon, 06 Jul 2015 20:19:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615574#comment-14615574
] 

Alan Gates commented on HIVE-11130:
-----------------------------------

The only comment I have is that in the HiveTxnManagerImpl implementations of lockTable, etc.
I think it would be good to call HiveTxnManger.supportsExplicitLock and throw if that returns
true.  This avoids an erroneous code path ending up there from DbTxnManager, which should
never call these methods.  

Other than that, +1.

> Refactoring the code so that HiveTxnManager interface will support lock/unlock table/database
object
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-11130
>                 URL: https://issues.apache.org/jira/browse/HIVE-11130
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Locking
>    Affects Versions: 2.0.0
>            Reporter: Aihua Xu
>            Assignee: Aihua Xu
>         Attachments: HIVE-11130.patch
>
>
> This is just a refactoring step which keeps the current logic, but it exposes the explicit
lock/unlock table and database  in HiveTxnManager which should be implemented differently
by the subclasses ( currently it's not. e.g., for ZooKeeper implementation, we should lock
table and database when we try to lock the table).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message