Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Tue, 2 Jun 2015 17:29:50 +0000 (UTC)
From: "Sushanth Sowmyan (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12834741.1433265965000.507.1433266190497@Atlassian.JIRA>
In-Reply-To: <JIRA.12834741.1433265965000@Atlassian.JIRA>
References: <JIRA.12834741.1433265965000@Atlassian.JIRA>
 <JIRA.12834741.1433265965301@arcas>
Subject: [jira] [Commented] (HIVE-10892) TestHCatClient should not accept
 external metastore param from -Dhive.metastore.uris
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569467#comment-14569467 ] 

Sushanth Sowmyan commented on HIVE-10892:
-----------------------------------------

[~thejas], can I bug you for a quick review?

> TestHCatClient should not accept external metastore param from -Dhive.metastore.uris
> ------------------------------------------------------------------------------------
>
>                 Key: HIVE-10892
>                 URL: https://issues.apache.org/jira/browse/HIVE-10892
>             Project: Hive
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.2.0
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-10892.patch
>
>
> HIVE-10074 added the ability to specify a -Dhive.metastore.uris from the commandline, so as to run the test against a deployed metastore.
> However, because of the way HiveConf is written, this results in that parameter always overriding any value specified in the conf passed into it for instantiation, since it accepts System Var Overrides. This results in some tests, notably those that attempt to connect between two metastores (such as TestHCatClient#testPartitionRegistrationWithCustomSchema to fail.
> Fixing this in HiveConf is not a good idea, since that behaviour is desired for HiveConf. Fixing this in HCatUtil.getHiveConf doesn't really work either, since that is a utility wrapper on HiveConf, and is supposed to behave similarly. Thus, the fix for this then becomes something to use in all our testcases, where we instantiate Configuration objects. It seems more appropriate to change the parameter we use to specify test parameters then, than to change each config object.
> Thus, we should change semantics for running this test against an external metastore by specifying the override in a different parameter name, say test.hive.metastore.uris, instead of hive.metastore.uris, which has a specific meaning.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)