hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gopal V (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11122) ORC should not record the timezone information when there are no timestamp columns
Date Sat, 27 Jun 2015 04:15:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603962#comment-14603962
] 

Gopal V commented on HIVE-11122:
--------------------------------

LGTM - +1 tests-pending.

Minor readability suggestions - renaming to useWriterTimeZone() + hasWriterTimeZone() to indicate
imperative + "has option" relationship instead of the current prefixes of (set* & is*).

> ORC should not record the timezone information when there are no timestamp columns
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-11122
>                 URL: https://issues.apache.org/jira/browse/HIVE-11122
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>         Attachments: HIVE-11122.patch
>
>
> Currently ORC records the time zone information in the stripe footer even when there
are no timestamp columns. This will not only add to the size of the footer but also can cause
inconsistencies (file size difference) in test cases when run under different time zones.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message