hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <>
Subject [jira] [Commented] (HIVE-10892) TestHCatClient should not accept external metastore param from -Dhive.metastore.uris
Date Tue, 02 Jun 2015 17:29:50 GMT


Sushanth Sowmyan commented on HIVE-10892:

[~thejas], can I bug you for a quick review?

> TestHCatClient should not accept external metastore param from -Dhive.metastore.uris
> ------------------------------------------------------------------------------------
>                 Key: HIVE-10892
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.2.0
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-10892.patch
> HIVE-10074 added the ability to specify a -Dhive.metastore.uris from the commandline,
so as to run the test against a deployed metastore.
> However, because of the way HiveConf is written, this results in that parameter always
overriding any value specified in the conf passed into it for instantiation, since it accepts
System Var Overrides. This results in some tests, notably those that attempt to connect between
two metastores (such as TestHCatClient#testPartitionRegistrationWithCustomSchema to fail.
> Fixing this in HiveConf is not a good idea, since that behaviour is desired for HiveConf.
Fixing this in HCatUtil.getHiveConf doesn't really work either, since that is a utility wrapper
on HiveConf, and is supposed to behave similarly. Thus, the fix for this then becomes something
to use in all our testcases, where we instantiate Configuration objects. It seems more appropriate
to change the parameter we use to specify test parameters then, than to change each config
> Thus, we should change semantics for running this test against an external metastore
by specifying the override in a different parameter name, say test.hive.metastore.uris, instead
of hive.metastore.uris, which has a specific meaning.

This message was sent by Atlassian JIRA

View raw message