hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-7180) BufferedReader is not closed in MetaStoreSchemaInfo ctor
Date Tue, 09 Jun 2015 16:37:01 GMT

     [ https://issues.apache.org/jira/browse/HIVE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated HIVE-7180:
-------------------------
    Description: 
Here is related code:
{code}
      BufferedReader bfReader =
        new BufferedReader(new FileReader(upgradeListFile));
      String currSchemaVersion;
      while ((currSchemaVersion = bfReader.readLine()) != null) {
        upgradeOrderList.add(currSchemaVersion.trim());
{code}
BufferedReader / FileReader should be closed upon return from ctor.

  was:
Here is related code:
{code}
      BufferedReader bfReader =
        new BufferedReader(new FileReader(upgradeListFile));
      String currSchemaVersion;
      while ((currSchemaVersion = bfReader.readLine()) != null) {
        upgradeOrderList.add(currSchemaVersion.trim());
{code}

BufferedReader / FileReader should be closed upon return from ctor.


> BufferedReader is not closed in MetaStoreSchemaInfo ctor
> --------------------------------------------------------
>
>                 Key: HIVE-7180
>                 URL: https://issues.apache.org/jira/browse/HIVE-7180
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.13.1
>            Reporter: Ted Yu
>            Assignee: skrho
>            Priority: Minor
>              Labels: patch
>         Attachments: HIVE-7180.patch, HIVE-7180_001.patch
>
>
> Here is related code:
> {code}
>       BufferedReader bfReader =
>         new BufferedReader(new FileReader(upgradeListFile));
>       String currSchemaVersion;
>       while ((currSchemaVersion = bfReader.readLine()) != null) {
>         upgradeOrderList.add(currSchemaVersion.trim());
> {code}
> BufferedReader / FileReader should be closed upon return from ctor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message