Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7831D18B77 for ; Fri, 29 May 2015 13:36:19 +0000 (UTC) Received: (qmail 77715 invoked by uid 500); 29 May 2015 13:36:18 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 77632 invoked by uid 500); 29 May 2015 13:36:18 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 77513 invoked by uid 99); 29 May 2015 13:36:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 May 2015 13:36:18 +0000 Date: Fri, 29 May 2015 13:36:18 +0000 (UTC) From: "Xuefu Zhang (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HIVE-10821) Beeline-CLI: Implement CLI source command using Beeline functionality MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-10821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564806#comment-14564806 ] Xuefu Zhang edited comment on HIVE-10821 at 5/29/15 1:36 PM: ------------------------------------------------------------- [~Ferd], thanks for working on this. If you're introducing the functionality of sourcing a script file in Beeline, I think we should follow Beeline's command style. That's is, all commands need to start with {noformat}!{noformat}, for instance, !sql, !connect, and now !source. A command without {noformat}!{noformat} is treated as if it is started with "!sql". Thus, if you execute a command like "source script.sql" in beeline, it should be equivalent to "!sql source script.sql", which isn't intuitive. I'd suggest we instead introduce "!source script.sql" as a general way to execute a script file in Beeline interactive mode. Then, for Hive CLI's beeline implementation, Hive CLI's "source script.sql" will be translated to "!source script.sql" via your translation method. Thoughts? was (Author: xuefuz): [~Ferd], thanks for working on this. If you're introducing the functionality of sourcing a script file in Beeline, I think we should follow Beeline's command style. That's is, all commands need to start with "!", for instance, !sql, !connect, and now !source. A command without "!" is treated as if it is started with "!sql". Thus, if you introduce a command like "source script.sql", it should be translated to "!sql source script.sql", which isn't intuitive. I'd suggest we instead introduce "!source script.sql" as the way to execute a script file in interactive mode. Then, for Hive CLI's beeline implementation, Hive CLI's "source script.sql" will be translated to "!source script.sql" via your translation method. Thoughts? > Beeline-CLI: Implement CLI source command using Beeline functionality > --------------------------------------------------------------------- > > Key: HIVE-10821 > URL: https://issues.apache.org/jira/browse/HIVE-10821 > Project: Hive > Issue Type: Sub-task > Components: CLI > Reporter: Ferdinand Xu > Assignee: Ferdinand Xu > Attachments: HIVE-10821.1-beeline-cli.patch, HIVE-10821.1-beeline-cli.patch, HIVE-10821.2-beeline-cli.patch, HIVE-10821.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)