Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Sun, 24 May 2015 07:22:17 +0000 (UTC)
From: "Hive QA (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12773163.1423265382000.18691.1432452137134@Atlassian.JIRA>
In-Reply-To: <JIRA.12773163.1423265382000@Atlassian.JIRA>
References: <JIRA.12773163.1423265382000@Atlassian.JIRA>
 <JIRA.12773163.1423265382227@arcas>
Subject: [jira] [Commented] (HIVE-9605) Remove parquet nested objects from
 wrapper writable objects
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HIVE-9605?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14557=
665#comment-14557665 ]=20

Hive QA commented on HIVE-9605:
-------------------------------


{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12735048/HIVE-9605.6.patch

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 8973 tests exe=
cuted
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_crc32
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_sha1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vector_join30
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_vector_null_p=
rojection
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job=
/PreCommit-HIVE-TRUNK-Build/4027/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/j=
ob/PreCommit-HIVE-TRUNK-Build/4027/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit=
-HIVE-TRUNK-Build-4027/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12735048 - PreCommit-HIVE-TRUNK-Build

> Remove parquet nested objects from wrapper writable objects
> -----------------------------------------------------------
>
>                 Key: HIVE-9605
>                 URL: https://issues.apache.org/jira/browse/HIVE-9605
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 0.14.0
>            Reporter: Sergio Pe=C3=B1a
>            Assignee: Sergio Pe=C3=B1a
>             Fix For: parquet-branch
>
>         Attachments: HIVE-9605.3.patch, HIVE-9605.4.patch, HIVE-9605.5.pa=
tch, HIVE-9605.6.patch
>
>
> Parquet nested types are using an extra wrapper object (ArrayWritable) as=
 a wrapper of map and list elements. This extra object is not needed and ca=
using unnecessary memory allocations.
> An example of code is on HiveCollectionConverter.java:
> {noformat}
> public void end() {
>     parent.set(index, wrapList(new ArrayWritable(
>         Writable.class, list.toArray(new Writable[list.size()]))));
> }
> {noformat}
> This object is later unwrapped on AbstractParquetMapInspector, i.e.:
> {noformat}
> final Writable[] mapContainer =3D ((ArrayWritable) data).get();
> final Writable[] mapArray =3D ((ArrayWritable) mapContainer[0]).get();
> for (final Writable obj : mapArray) {
>   ...
> }
> {noformat}
> We should get rid of this wrapper object to save time and memory.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)