Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD91918CE4 for ; Thu, 14 May 2015 08:43:59 +0000 (UTC) Received: (qmail 40240 invoked by uid 500); 14 May 2015 08:43:59 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 40218 invoked by uid 500); 14 May 2015 08:43:59 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 40208 invoked by uid 99); 14 May 2015 08:43:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2015 08:43:59 +0000 Date: Thu, 14 May 2015 08:43:59 +0000 (UTC) From: "Lars Francke (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-8583) HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated HIVE-8583: ------------------------------- Description: [~alangates] added the following in HIVE-8341: {code} String bl = hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString()); if (bl != null && bl.length() > 0) { String[] bls = bl.split(","); for (String b : bls) { b.replaceAll(".", "_"); blackListedConfEntries.add(b); } } {code} The {{replaceAll}} call is confusing as its result is not used at all. This patch contains the following: * Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST * Removes replaceAll * Lets blackListed take a Configuration job as parameter which allowed me to add a test for this * Tabs to Spaces conversion was: [~alangates] added the following in HIVE-8341: {code} String bl = hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString()); if (bl != null && bl.length() > 0) { String[] bls = bl.split(","); for (String b : bls) { b.replaceAll(".", "_"); blackListedConfEntries.add(b); } } {code} The {{replaceAll}} call is confusing as its result is not used at all. This patch contains the following: * Minor style modification (missorted modifiers) * Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST * Removes replaceAll * Lets blackListed take a Configuration job as parameter which allowed me to add a test for this * Tabs to Spaces conversion > HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist > --------------------------------------------------------------- > > Key: HIVE-8583 > URL: https://issues.apache.org/jira/browse/HIVE-8583 > Project: Hive > Issue Type: Improvement > Reporter: Lars Francke > Assignee: Lars Francke > Priority: Minor > Attachments: HIVE-8583.1.patch, HIVE-8583.2.patch, HIVE-8583.3.patch, HIVE-8583.4.patch > > > [~alangates] added the following in HIVE-8341: > {code} > String bl = hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString()); > if (bl != null && bl.length() > 0) { > String[] bls = bl.split(","); > for (String b : bls) { > b.replaceAll(".", "_"); > blackListedConfEntries.add(b); > } > } > {code} > The {{replaceAll}} call is confusing as its result is not used at all. > This patch contains the following: > * Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST > * Removes replaceAll > * Lets blackListed take a Configuration job as parameter which allowed me to add a test for this > * Tabs to Spaces conversion -- This message was sent by Atlassian JIRA (v6.3.4#6332)