Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Mon, 18 May 2015 04:16:00 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12718673.1401987401000.139837.1431922560451@Atlassian.JIRA>
In-Reply-To: <JIRA.12718673.1401987401000@Atlassian.JIRA>
References: <JIRA.12718673.1401987401000@Atlassian.JIRA>
 <JIRA.12718673.1401987401825@arcas>
Subject: [jira] [Updated] (HIVE-7180) BufferedReader is not closed in
 MetaStoreSchemaInfo ctor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HIVE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HIVE-7180:
-------------------------
    Description: 
Here is related code:
{code}
      BufferedReader bfReader =
        new BufferedReader(new FileReader(upgradeListFile));
      String currSchemaVersion;
      while ((currSchemaVersion = bfReader.readLine()) != null) {
        upgradeOrderList.add(currSchemaVersion.trim());
{code}

BufferedReader / FileReader should be closed upon return from ctor.

  was:
Here is related code:
{code}
      BufferedReader bfReader =
        new BufferedReader(new FileReader(upgradeListFile));
      String currSchemaVersion;
      while ((currSchemaVersion = bfReader.readLine()) != null) {
        upgradeOrderList.add(currSchemaVersion.trim());
{code}
BufferedReader / FileReader should be closed upon return from ctor.


> BufferedReader is not closed in MetaStoreSchemaInfo ctor
> --------------------------------------------------------
>
>                 Key: HIVE-7180
>                 URL: https://issues.apache.org/jira/browse/HIVE-7180
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.13.1
>            Reporter: Ted Yu
>            Assignee: skrho
>            Priority: Minor
>              Labels: patch
>         Attachments: HIVE-7180.patch, HIVE-7180_001.patch
>
>
> Here is related code:
> {code}
>       BufferedReader bfReader =
>         new BufferedReader(new FileReader(upgradeListFile));
>       String currSchemaVersion;
>       while ((currSchemaVersion = bfReader.readLine()) != null) {
>         upgradeOrderList.add(currSchemaVersion.trim());
> {code}
> BufferedReader / FileReader should be closed upon return from ctor.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)