hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Sankar Sivarama Subramaniyan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-10768) In QTestGenTask.execute() we should not throw an exception right away if we are unable to clean any old files
Date Wed, 20 May 2015 08:05:59 GMT

     [ https://issues.apache.org/jira/browse/HIVE-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hari Sankar Sivarama Subramaniyan updated HIVE-10768:
-----------------------------------------------------
    Attachment: HIVE-10768.1.patch

> In QTestGenTask.execute() we should not throw an exception right away if we are unable
to clean any old files
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-10768
>                 URL: https://issues.apache.org/jira/browse/HIVE-10768
>             Project: Hive
>          Issue Type: Bug
>          Components: Testing Infrastructure
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-10768.1.patch
>
>
> Currently in QTestGenTask.execute(), we have code like :
> {code}
>        if (logFile != null) {
>          File lf = new File(logFile);
>          if (lf.exists()) {
>            if (!lf.delete()) {
>              throw new Exception("Could not delete log file " + lf.getCanonicalPath());
>          }
> {code}
> If the log file gets locked due to some other process, it throws the above exception
and short circuits the entire test suite. We should provide a mechanism to generate alternative
new log files/temporary files whenever possible to avoid unit test failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message