hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chaoyu Tang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-10587) ExprNodeColumnDesc should be created with isPartitionColOrVirtualCol true for DP column
Date Sun, 03 May 2015 20:34:06 GMT

     [ https://issues.apache.org/jira/browse/HIVE-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chaoyu Tang updated HIVE-10587:
-------------------------------
    Attachment: HIVE-10587.patch

A simple patch. Passing true as parameter isPartitionColOrVirtualCol value to ExprNodeColumnDesc
constructor.
[~ashutoshc], [~szehon] could you take a look to see if it makes sense? Thanks

> ExprNodeColumnDesc should be created with isPartitionColOrVirtualCol true for DP column
> ---------------------------------------------------------------------------------------
>
>                 Key: HIVE-10587
>                 URL: https://issues.apache.org/jira/browse/HIVE-10587
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 1.0.0
>            Reporter: Chaoyu Tang
>            Assignee: Chaoyu Tang
>            Priority: Minor
>         Attachments: HIVE-10587.patch
>
>
> In SymenticAnalyzer method: 
> Operator genConversionSelectOperator(String dest, QB qb, Operator input, TableDesc table_desc,
DynamicPartitionCtx dpCtx) throws SemanticException
> ==
> The DP column's ExprNodeColumnDesc is created by passing false as the parameter isPartitionColOrVirtualCol
value:
> {code}
>       // DP columns starts with tableFields.size()
>       for (int i = tableFields.size() + (updating() ? 1 : 0); i < rowFields.size();
++i) {
>         TypeInfo rowFieldTypeInfo = rowFields.get(i).getType();
>         ExprNodeDesc column = new ExprNodeColumnDesc(
>             rowFieldTypeInfo, rowFields.get(i).getInternalName(), "", false);
>         expressions.add(column);
>       }
> {code}
> I think it should be true instead. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message