hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Pivovarov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-10580) Fix impossible cast in GenericUDF.getConstantLongValue
Date Wed, 13 May 2015 22:03:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542814#comment-14542814
] 

Alexander Pivovarov commented on HIVE-10580:
--------------------------------------------

Lets look at the following facts
- after we fix the bug the implementation will be correct.
- name of the method is also good, we do not have other method which replaces it.
- currently the method is not used in UDFs which exist in hive-exec project
- the method might be used in hive users custom UDFs

Hive is not just a product itself. Hive is an extendable platform. End-users can develop their
own UDFs, Serde, etc.
The platform should provide clear and useful interfaces for external developers.

Do you still want to deprecate useful base class method with correct name and implementation
just because it's not used in hive-exec itself?

> Fix impossible cast in GenericUDF.getConstantLongValue
> ------------------------------------------------------
>
>                 Key: HIVE-10580
>                 URL: https://issues.apache.org/jira/browse/HIVE-10580
>             Project: Hive
>          Issue Type: Bug
>          Components: UDF
>            Reporter: Alexander Pivovarov
>            Assignee: Alexander Pivovarov
>         Attachments: HIVE-10580.1.patch
>
>
> line 548-549
> {code}
>     if (constValue instanceof IntWritable) {
>       v = ((LongWritable) constValue).get();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message