hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-10539) set default value of hive.repl.task.factory
Date Mon, 04 May 2015 20:48:06 GMT

    [ https://issues.apache.org/jira/browse/HIVE-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527261#comment-14527261
] 

Sushanth Sowmyan commented on HIVE-10539:
-----------------------------------------

Thanks for the test change, Thejas, I'm +1 on that, but I'm not sure that we need the change
to ReplicationTask to change the factory instantiation from an anonymous factory that throws
errors on calling .create to simply throwing an exception. That actually undoes a change I
added in after review feedback to how it was before the feedback. :)

The difference is that in the former case, we do not try to re-instantiate the factory at
every call - we simply fail on the create being called. If we failed the first time because
reflection could not instantiate the provided factory, there is no reason it will be recoverable
from.

> set default value of hive.repl.task.factory
> -------------------------------------------
>
>                 Key: HIVE-10539
>                 URL: https://issues.apache.org/jira/browse/HIVE-10539
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: Thejas M Nair
>         Attachments: HIVE-10539.1.patch, HIVE-10539.2.patch
>
>
> hive.repl.task.factory does not have a default value set. It should be set to org.apache.hive.hcatalog.api.repl.exim.EximReplicationTaskFactory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message