hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ferdinand Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9605) Remove parquet nested objects from wrapper writable objects
Date Mon, 25 May 2015 00:59:17 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557905#comment-14557905
] 

Ferdinand Xu commented on HIVE-9605:
------------------------------------

Thanks [~spena], LGTM  +1

> Remove parquet nested objects from wrapper writable objects
> -----------------------------------------------------------
>
>                 Key: HIVE-9605
>                 URL: https://issues.apache.org/jira/browse/HIVE-9605
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 0.14.0
>            Reporter: Sergio Peña
>            Assignee: Sergio Peña
>             Fix For: parquet-branch
>
>         Attachments: HIVE-9605.3.patch, HIVE-9605.4.patch, HIVE-9605.5.patch, HIVE-9605.6.patch
>
>
> Parquet nested types are using an extra wrapper object (ArrayWritable) as a wrapper of
map and list elements. This extra object is not needed and causing unnecessary memory allocations.
> An example of code is on HiveCollectionConverter.java:
> {noformat}
> public void end() {
>     parent.set(index, wrapList(new ArrayWritable(
>         Writable.class, list.toArray(new Writable[list.size()]))));
> }
> {noformat}
> This object is later unwrapped on AbstractParquetMapInspector, i.e.:
> {noformat}
> final Writable[] mapContainer = ((ArrayWritable) data).get();
> final Writable[] mapArray = ((ArrayWritable) mapContainer[0]).get();
> for (final Writable obj : mapArray) {
>   ...
> }
> {noformat}
> We should get rid of this wrapper object to save time and memory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message