hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-8583) HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist
Date Thu, 14 May 2015 08:43:59 GMT

     [ https://issues.apache.org/jira/browse/HIVE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lars Francke updated HIVE-8583:
-------------------------------
    Description: 
[~alangates] added the following in HIVE-8341:

{code}
        String bl = hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString());
        if (bl != null && bl.length() > 0) {
          String[] bls = bl.split(",");
          for (String b : bls) {
            b.replaceAll(".", "_");
            blackListedConfEntries.add(b);
          }
        }
{code}

The {{replaceAll}} call is confusing as its result is not used at all.

This patch contains the following:

* Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST
* Removes replaceAll
* Lets blackListed take a Configuration job as parameter which allowed me to add a test for
this
* Tabs to Spaces conversion

  was:
[~alangates] added the following in HIVE-8341:

{code}
        String bl = hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString());
        if (bl != null && bl.length() > 0) {
          String[] bls = bl.split(",");
          for (String b : bls) {
            b.replaceAll(".", "_");
            blackListedConfEntries.add(b);
          }
        }
{code}

The {{replaceAll}} call is confusing as its result is not used at all.

This patch contains the following:

* Minor style modification (missorted modifiers)
* Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST
* Removes replaceAll
* Lets blackListed take a Configuration job as parameter which allowed me to add a test for
this
* Tabs to Spaces conversion


> HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist
> ---------------------------------------------------------------
>
>                 Key: HIVE-8583
>                 URL: https://issues.apache.org/jira/browse/HIVE-8583
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-8583.1.patch, HIVE-8583.2.patch, HIVE-8583.3.patch, HIVE-8583.4.patch
>
>
> [~alangates] added the following in HIVE-8341:
> {code}
>         String bl = hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString());
>         if (bl != null && bl.length() > 0) {
>           String[] bls = bl.split(",");
>           for (String b : bls) {
>             b.replaceAll(".", "_");
>             blackListedConfEntries.add(b);
>           }
>         }
> {code}
> The {{replaceAll}} call is confusing as its result is not used at all.
> This patch contains the following:
> * Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST
> * Removes replaceAll
> * Lets blackListed take a Configuration job as parameter which allowed me to add a test
for this
> * Tabs to Spaces conversion



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message