Return-Path: 
 <issues-return-3923-apmail-hive-issues-archive=hive.apache.org@hive.apache.org>
X-Original-To: apmail-hive-issues-archive@minotaur.apache.org
Delivered-To: apmail-hive-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6396917F79
	for <apmail-hive-issues-archive@minotaur.apache.org>;
 Thu,  9 Apr 2015 10:25:25 +0000 (UTC)
Received: (qmail 57156 invoked by uid 500); 9 Apr 2015 10:25:12 -0000
Delivered-To: apmail-hive-issues-archive@hive.apache.org
Received: (qmail 57137 invoked by uid 500); 9 Apr 2015 10:25:12 -0000
Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hive.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hive.apache.org>
List-Post: <mailto:issues@hive.apache.org>
List-Id: <issues.hive.apache.org>
Reply-To: dev@hive.apache.org
Delivered-To: mailing list issues@hive.apache.org
Received: (qmail 57127 invoked by uid 99); 9 Apr 2015 10:25:12 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Apr 2015 10:25:12 +0000
Date: Thu, 9 Apr 2015 10:25:12 +0000 (UTC)
From: "Anant Nag (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12819144.1428455346000.38422.1428575112127@Atlassian.JIRA>
In-Reply-To: <JIRA.12819144.1428455346000@Atlassian.JIRA>
References: <JIRA.12819144.1428455346000@Atlassian.JIRA>
 <JIRA.12819144.1428455346544@arcas>
Subject: [jira] [Commented] (HIVE-10251) HIVE-9664 makes hive depend on
 ivysettings.xml
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HIVE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487094#comment-14487094 ] 

Anant Nag commented on HIVE-10251:
----------------------------------

hi [~sushanth],

I've addressed the comments in the rb and updated the patch. I'm not sure about how to do unit testing on this since ivysettings.xml file is added to the classpath while running unit tests. Also there is a default  defaultGrapeConfig.xml file shipped in the groovy jar which will be used if ivysettings.xml is not found in the classpath. Any suggestions or comments on how to do this?

> HIVE-9664 makes hive depend on ivysettings.xml
> ----------------------------------------------
>
>                 Key: HIVE-10251
>                 URL: https://issues.apache.org/jira/browse/HIVE-10251
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 1.2.0
>            Reporter: Sushanth Sowmyan
>            Assignee: Anant Nag
>              Labels: patch
>         Attachments: HIVE-10251.1.patch, HIVE-10251.2.patch, HIVE-10251.simple.patch
>
>
> HIVE-9664 makes hive depend on the existence of ivysettings.xml, and if it is not present, it makes hive NPE when instantiating a CLISessionState.
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.hive.ql.session.DependencyResolver.<init>(DependencyResolver.java:61)
> at org.apache.hadoop.hive.ql.session.SessionState.<init>(SessionState.java:343)
> at org.apache.hadoop.hive.ql.session.SessionState.<init>(SessionState.java:334)
> at org.apache.hadoop.hive.cli.CliSessionState.<init>(CliSessionState.java:60)
> {noformat}
> This happens because of the following bit:
> {noformat}
>     // If HIVE_HOME is not defined or file is not found in HIVE_HOME/conf then load default ivysettings.xml from class loader
>     if (ivysettingsPath == null || !(new File(ivysettingsPath).exists())) {
>       ivysettingsPath = ClassLoader.getSystemResource("ivysettings.xml").getFile();
>       _console.printInfo("ivysettings.xml file not found in HIVE_HOME or HIVE_CONF_DIR," + ivysettingsPath + " will be used");
>     }
> {noformat}
> This makes it so that an attempt to instantiate CliSessionState without an ivysettings.xml file will cause hive to fail with an NPE. Hive should not have a hard dependency on a ivysettings,xml being present, and this feature should gracefully fail in that case instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)