Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE5E317D35 for ; Thu, 2 Apr 2015 19:56:56 +0000 (UTC) Received: (qmail 13968 invoked by uid 500); 2 Apr 2015 19:56:53 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 13951 invoked by uid 500); 2 Apr 2015 19:56:53 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 13941 invoked by uid 99); 2 Apr 2015 19:56:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2015 19:56:53 +0000 Date: Thu, 2 Apr 2015 19:56:53 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-10031) Modify the using of jobConf variable in ParquetRecordReaderWrapper constructor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393257#comment-14393257 ] Hive QA commented on HIVE-10031: -------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12708935/HIVE-10031.patch {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 8693 tests executed *Failed tests:* {noformat} TestMinimrCliDriver-smb_mapjoin_8.q - did not produce a TEST-*.xml file org.apache.hive.spark.client.TestSparkClient.testSyncRpc {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3253/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3253/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3253/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12708935 - PreCommit-HIVE-TRUNK-Build > Modify the using of jobConf variable in ParquetRecordReaderWrapper constructor > ------------------------------------------------------------------------------ > > Key: HIVE-10031 > URL: https://issues.apache.org/jira/browse/HIVE-10031 > Project: Hive > Issue Type: Sub-task > Reporter: Dong Chen > Assignee: Dong Chen > Attachments: HIVE-10031-parquet.patch, HIVE-10031.1-parquet.patch, HIVE-10031.patch > > > In {{ParquetRecordReaderWrapper}} constructor, it create splits, set projections and filters in conf, create task context, and then create Parquet record reader. In this procedure, we could improve the logic of conf usage: > 1. the updated jobConf is not passed to Parquet in one case. (https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetRecordReaderWrapper.java#L103) > I think we should use the instance variable {{jobConf}}, which is updated when projectioning and filtering, instead of passed in {{oldJobConf}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)