hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-10521) TxnHandler.timeOutTxns only times out some of the expired transactions
Date Tue, 28 Apr 2015 21:44:07 GMT

     [ https://issues.apache.org/jira/browse/HIVE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alan Gates updated HIVE-10521:
------------------------------
    Attachment: HIVE-10521.patch

Attaching a patch that changes timeOutTxns to loop through and time out all old transactions
instead of only the first 20 it finds.

[~ekoifman], can you review this?

[~sushanth], can I commit this to the 1.2 branch?

> TxnHandler.timeOutTxns only times out some of the expired transactions
> ----------------------------------------------------------------------
>
>                 Key: HIVE-10521
>                 URL: https://issues.apache.org/jira/browse/HIVE-10521
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 0.14.0, 1.0.0, 1.1.0
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: HIVE-10521.patch
>
>
> {code}
>       for (int i = 0; i < 20 && rs.next(); i++) deadTxns.add(rs.getLong(1));
>       // We don't care whether all of the transactions get deleted or not,
>       // if some didn't it most likely means someone else deleted them in the interum
>       if (deadTxns.size() > 0) abortTxns(dbConn, deadTxns);
> {code}
> While it makes sense to limit the number of transactions aborted in one pass (since this
get's translated to an IN clause) we should still make sure all are timed out.  Also, 20 seems
pretty small as a batch size.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message