hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Pivovarov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-10501) remove HashTableSinkDesc fields which hide base class fields
Date Mon, 27 Apr 2015 18:39:39 GMT

     [ https://issues.apache.org/jira/browse/HIVE-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alexander Pivovarov updated HIVE-10501:
---------------------------------------
    Attachment: HIVE-10501.1.patch

patch #1

> remove HashTableSinkDesc fields which hide base class fields
> ------------------------------------------------------------
>
>                 Key: HIVE-10501
>                 URL: https://issues.apache.org/jira/browse/HIVE-10501
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Planning
>            Reporter: Alexander Pivovarov
>            Assignee: Alexander Pivovarov
>            Priority: Minor
>         Attachments: HIVE-10501.1.patch
>
>
> The following HashTableSinkDesc fields are also present in the base class (JoinDesc):
> {code}
> // used to handle skew join
> private boolean handleSkewJoin = false;
> private int skewKeyDefinition = -1;
> private Map<Byte, Path> bigKeysDirMap;
> private Map<Byte, Map<Byte, Path>> smallKeysDirMap;
> private Map<Byte, TableDesc> skewKeysValuesTables;
> // alias to key mapping
> private Map<Byte, List<ExprNodeDesc>> exprs;
> // alias to filter mapping
> private Map<Byte, List<ExprNodeDesc>> filters;
> // outerjoin-pos = other-pos:filter-len, other-pos:filter-len, ...
> private int[][] filterMap;
> // used for create joinOutputObjectInspector
> protected List<String> outputColumnNames;
> // key:column output name, value:tag
> private transient Map<String, Byte> reversedExprs;
> // No outer join involved
> protected boolean noOuterJoin;
> protected JoinCondDesc[] conds;
> protected Byte[] tagOrder;
> private TableDesc keyTableDesc;
> {code}
> Probably we should remove them and use base class (JoinDesc) fields instead



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message