hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-10477) Provide option to disable Spark tests
Date Fri, 24 Apr 2015 19:53:38 GMT

    [ https://issues.apache.org/jira/browse/HIVE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511624#comment-14511624
] 

Sushanth Sowmyan commented on HIVE-10477:
-----------------------------------------

Makes sense, +1.

I like the !skipSparkTests approach for profile activation, so that by default the spark-test
profile will be included - this means our precommit tests will not be affected. Eventually,
though, we should get back to adding in appropriate .cmd equivalents so that the download-spark
execution works under windows as well.

> Provide option to disable Spark tests 
> --------------------------------------
>
>                 Key: HIVE-10477
>                 URL: https://issues.apache.org/jira/browse/HIVE-10477
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-10477.1.patch
>
>
> The following is one of the reasons why we might want to provide an option to disable
spark tests :
> In the current master branch, unit tests fail with windows OS because of the dependency
on "bash" executable in itests/hive-unit/pom.xml around these lines :
> {code}
>                  <target>
>                     <exec executable="bash" dir="${basedir}" failonerror="true">
>                       <arg line="../target/download.sh"/>
>                     </exec>
>                   </target>
> {code}
> We should provide an option to disable spark tests in OSes  like Windows where bash might
be absent. That being mentioned, spark tests will be enabled by default in pre-commit test
runs and should still continue to work as it is in the master branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message