hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anant Nag (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-10251) HIVE-9664 makes hive depend on ivysettings.xml
Date Thu, 09 Apr 2015 10:25:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487094#comment-14487094
] 

Anant Nag commented on HIVE-10251:
----------------------------------

hi [~sushanth],

I've addressed the comments in the rb and updated the patch. I'm not sure about how to do
unit testing on this since ivysettings.xml file is added to the classpath while running unit
tests. Also there is a default  defaultGrapeConfig.xml file shipped in the groovy jar which
will be used if ivysettings.xml is not found in the classpath. Any suggestions or comments
on how to do this?

> HIVE-9664 makes hive depend on ivysettings.xml
> ----------------------------------------------
>
>                 Key: HIVE-10251
>                 URL: https://issues.apache.org/jira/browse/HIVE-10251
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 1.2.0
>            Reporter: Sushanth Sowmyan
>            Assignee: Anant Nag
>              Labels: patch
>         Attachments: HIVE-10251.1.patch, HIVE-10251.2.patch, HIVE-10251.simple.patch
>
>
> HIVE-9664 makes hive depend on the existence of ivysettings.xml, and if it is not present,
it makes hive NPE when instantiating a CLISessionState.
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.hive.ql.session.DependencyResolver.<init>(DependencyResolver.java:61)
> at org.apache.hadoop.hive.ql.session.SessionState.<init>(SessionState.java:343)
> at org.apache.hadoop.hive.ql.session.SessionState.<init>(SessionState.java:334)
> at org.apache.hadoop.hive.cli.CliSessionState.<init>(CliSessionState.java:60)
> {noformat}
> This happens because of the following bit:
> {noformat}
>     // If HIVE_HOME is not defined or file is not found in HIVE_HOME/conf then load default
ivysettings.xml from class loader
>     if (ivysettingsPath == null || !(new File(ivysettingsPath).exists())) {
>       ivysettingsPath = ClassLoader.getSystemResource("ivysettings.xml").getFile();
>       _console.printInfo("ivysettings.xml file not found in HIVE_HOME or HIVE_CONF_DIR,"
+ ivysettingsPath + " will be used");
>     }
> {noformat}
> This makes it so that an attempt to instantiate CliSessionState without an ivysettings.xml
file will cause hive to fail with an NPE. Hive should not have a hard dependency on a ivysettings,xml
being present, and this feature should gracefully fail in that case instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message