hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gunther Hagleitner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-10233) Hive on LLAP: Memory manager
Date Tue, 28 Apr 2015 21:46:06 GMT

    [ https://issues.apache.org/jira/browse/HIVE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518152#comment-14518152
] 

Gunther Hagleitner commented on HIVE-10233:
-------------------------------------------

I'm still reviewing, but there are some changes in this that I think is unnecessary. I think
you've renamed the llap memory manager to MemoryManagerInterface to make room for another
MemoryManager (ql/exec/MemoryManager). But that one isn't used. You really use the ExecMemoryManager.


So - you could roll back the changes to the llap cache, remove the old memory manager and
just use the exec one. That simplifies the patch.

I also think you don't need a memory manager class at all. All it does is remember a field
per operator. It seems cleaner to add memInfo to the operator base class with some facilities
to track memory. (or introduce a class between operator and gby/join/rs).

> Hive on LLAP: Memory manager
> ----------------------------
>
>                 Key: HIVE-10233
>                 URL: https://issues.apache.org/jira/browse/HIVE-10233
>             Project: Hive
>          Issue Type: Bug
>          Components: Tez
>    Affects Versions: llap
>            Reporter: Vikram Dixit K
>            Assignee: Vikram Dixit K
>         Attachments: HIVE-10233-WIP-2.patch, HIVE-10233-WIP-3.patch, HIVE-10233-WIP-4.patch,
HIVE-10233-WIP-5.patch
>
>
> We need a memory manager in llap/tez to manage the usage of memory across threads. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message