hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-10163) CommonMergeJoinOperator calls WritableComparator.get() in the inner loop
Date Fri, 03 Apr 2015 06:21:53 GMT

    [ https://issues.apache.org/jira/browse/HIVE-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394122#comment-14394122
] 

Hive QA commented on HIVE-10163:
--------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12709041/HIVE-10163.3.patch

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 8693 tests executed
*Failed tests:*
{noformat}
TestMinimrCliDriver-smb_mapjoin_8.q - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_remote_script
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_root_dir_external_table
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_scriptfile1
org.apache.hive.jdbc.TestSSL.testSSLFetchHttp
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3259/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3259/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3259/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12709041 - PreCommit-HIVE-TRUNK-Build

> CommonMergeJoinOperator calls WritableComparator.get() in the inner loop
> ------------------------------------------------------------------------
>
>                 Key: HIVE-10163
>                 URL: https://issues.apache.org/jira/browse/HIVE-10163
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 1.2.0
>            Reporter: Gopal V
>            Assignee: Gunther Hagleitner
>              Labels: JOIN, Performance
>         Attachments: HIVE-10163.1.patch, HIVE-10163.2.patch, HIVE-10163.3.patch, mergejoin-comparekeys.png,
mergejoin-parallel-bt.png, mergejoin-parallel-lock.png
>
>
> The CommonMergeJoinOperator wastes CPU looking up the correct comparator for each WritableComparable
in each row.
> {code}
> @SuppressWarnings("rawtypes")
>   private int compareKeys(List<Object> k1, List<Object> k2) {
>     int ret = 0;
> ....   
>       ret = WritableComparator.get(key_1.getClass()).compare(key_1, key_2);
>       if (ret != 0) {
>         return ret;
>       }
>     }
> {code}
> !mergejoin-parallel-lock.png!
> !mergejoin-comparekeys.png!
> The slow part of that get() is deep within {{ReflectionUtils.setConf}}, where it tries
to use reflection to set the Comparator config for each row being compared.
> !mergejoin-parallel-bt.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message