hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanth Jayachandran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9711) ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN
Date Fri, 03 Apr 2015 01:33:53 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393899#comment-14393899
] 

Prasanth Jayachandran commented on HIVE-9711:
---------------------------------------------

[~gopalv] The patch mostly looks good.
1) Branch for batchSize > 1 and batchSize == 1 can be combined together into else condition
and initializing repeating variable based on the batch size.
2) nit: multiple checks in for() makes it go beyond 100 chars column width.


> ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-9711
>                 URL: https://issues.apache.org/jira/browse/HIVE-9711
>             Project: Hive
>          Issue Type: Bug
>          Components: File Formats, Vectorization
>    Affects Versions: 1.2.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>             Fix For: 1.2.0
>
>         Attachments: HIVE-9711.1.patch
>
>
> The isRepeating=true check uses Java equality, which results in NaN != NaN comparison
operations.
> The noNulls case needs the current check folded into the previous loop, while the hasNulls
case needs a logical AND of the isNull[] field instead of == comparisons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message