hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mithun Radhakrishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9609) AddPartitionMessage.getPartitions() can return null
Date Tue, 07 Apr 2015 22:00:16 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484171#comment-14484171
] 

Mithun Radhakrishnan commented on HIVE-9609:
--------------------------------------------

@[~sushanth]: 

1-2. I agree with you, and hence, me again. (?!) {{List<List<PartVal>>}} might
be doable, but we can hit that with a separate JIRA. The rest of the iterator stuff is pretty
neat. I'll read through the updated patch more closely before +1-ing.
3. That was likely my (IDE's) doing. Much obliged, and many simultaneous apologies.

I had recommended a change to {{AuthorizationPreEventListener.authorizeAddPartition}} to use
the alternative {{PartitionWrapper}} constructor. (It's way faster.) But again, it's possible
that that change distracts from our objective here. Separate JIRA?

> AddPartitionMessage.getPartitions() can return null
> ---------------------------------------------------
>
>                 Key: HIVE-9609
>                 URL: https://issues.apache.org/jira/browse/HIVE-9609
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 1.2.0
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-9609.2.patch, HIVE-9609.3.patch, HIVE-9609.patch
>
>
> DbNotificationListener and NotificationListener both depend on AddPartitionEvent.getPartitions()
to get their partitions to trigger a message, but this can be null if an AddPartitionEvent
was initialized on a PartitionSpec rather than a List<Partition>.
> Also, AddPartitionEvent seems to have a duality, where getPartitions() works only if
instantiated on a List<Partition>, and getPartitionIterator() works only if instantiated
on a PartitionSpec.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message