Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Mon, 16 Mar 2015 22:49:38 +0000 (UTC)
From: =?utf-8?Q?Sergio_Pe=C3=B1a_=28JIRA=29?= <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12782293.1426527218000.110519.1426546178390@Atlassian.JIRA>
In-Reply-To: <JIRA.12782293.1426527218000@Atlassian.JIRA>
References: <JIRA.12782293.1426527218000@Atlassian.JIRA>
 <JIRA.12782293.1426527218367@arcas>
Subject: [jira] [Updated] (HIVE-9981) Avoid throwing many exceptions when
 attempting to create new hdfs encryption shim
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/HIVE-9981?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergio Pe=C3=B1a updated HIVE-9981:
------------------------------
    Attachment: HIVE-9981.2.patch

Thanks [~thejas]
I did not see that issue. This patch uses a Boolean object instead to keep =
track of the encryption support.

> Avoid throwing many exceptions when attempting to create new hdfs encrypt=
ion shim
> -------------------------------------------------------------------------=
--------
>
>                 Key: HIVE-9981
>                 URL: https://issues.apache.org/jira/browse/HIVE-9981
>             Project: Hive
>          Issue Type: Improvement
>          Components: Encryption
>            Reporter: Sergio Pe=C3=B1a
>            Assignee: Sergio Pe=C3=B1a
>         Attachments: HIVE-9981.1.patch, HIVE-9981.2.patch
>
>
> Hadoop23Shims.createHdfsEncryptionShim() is throwing an exception for ver=
ions lower than 2.6.0 everytime a query is executed.
> Exceptions are expensive, so rather than throwing them every time, we can=
 use this design pattern followed for some other functions in Hadoop23Shims=
 -
> {code}
>   protected static final Method accessMethod;
>   protected static final Method getPasswordMethod;
>   static {
>     Method m =3D null;
>     try {
>       m =3D FileSystem.class.getMethod("access", Path.class, FsAction.cla=
ss);
>     } catch (NoSuchMethodException err) {
>       // This version of Hadoop does not support FileSystem.access().
>     }
>     accessMethod =3D m;
>     try {
>       m =3D Configuration.class.getMethod("getPassword", String.class);
>     } catch (NoSuchMethodException err) {
>       // This version of Hadoop does not support getPassword(), just retr=
ieve password from conf.
>       m =3D null;
>     }
>     getPasswordMethod =3D m;
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)