hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ferdinand Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-10031) Modify the using of jobConf variable in ParquetRecordReaderWrapper constructor
Date Mon, 23 Mar 2015 03:11:11 GMT

    [ https://issues.apache.org/jira/browse/HIVE-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375332#comment-14375332
] 

Ferdinand Xu commented on HIVE-10031:
-------------------------------------

Sorry for out of format.
{noformat} jobConf = projectionPusher.pushProjectionsAndFilters(conf, finalPath.getParent());
{noformat}
{noformat}
if (skipTimestampConversion ^ HiveConf.getBoolVar(
conf, HiveConf.ConfVars.HIVE_PARQUET_TIMESTAMP_SKIP_CONVERSION))
{ 
  conf = new JobConf(oldJobConf);  // is it needed?
  HiveConf.setBoolVar(conf, HiveConf.ConfVars.HIVE_PARQUET_TIMESTAMP_SKIP_CONVERSION, skipTimestampConversion);

}
{noformat}

> Modify the using of jobConf variable in ParquetRecordReaderWrapper constructor
> ------------------------------------------------------------------------------
>
>                 Key: HIVE-10031
>                 URL: https://issues.apache.org/jira/browse/HIVE-10031
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Dong Chen
>            Assignee: Dong Chen
>         Attachments: HIVE-10031-parquet.patch
>
>
> In {{ParquetRecordReaderWrapper}} constructor, it create splits, set projections and
filters in conf, create task context, and then create Parquet record reader. In this procedure,
we could improve the logic of conf usage:
> 1. the clone of jobConf is not necessary. This could speed up getRecordReader a little.
> 2. the updated jobConf is not passed to Parquet in one case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message