hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikram Dixit K (JIRA)" <>
Subject [jira] [Commented] (HIVE-9971) Clean up operator class
Date Tue, 17 Mar 2015 23:20:38 GMT


Vikram Dixit K commented on HIVE-9971:

Latest iteration looks good to me. +1 pending test results.

> Clean up operator class
> -----------------------
>                 Key: HIVE-9971
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Gunther Hagleitner
>            Assignee: Gunther Hagleitner
>         Attachments: HIVE-9971.1.patch, HIVE-9971.2.patch, HIVE-9971.3.patch, HIVE-9971.4.patch,
> This is mostly cleanup although it does enhance the pipeline in one respect. It introduces
asyn init for operators and uses it for hash table loading where desired.
> There's a bunch of weird code associated with the operator class:
> - initialize isn't recursive, rather initializeOp is supposed to call initializeChildren.
That has led to bugs in the past.
> - setExecContext and passExecContext. Both are recursive, but passExecContext calls setExecContext
and then recurses again. Boo.
> - lots of (getChildren() != null) although that can't happen anymore
> - TezCacheAccess is a hack. We should just leave init of inputs up to the operator that
needs it.
> - Need some sanity checks that make sure that operators were all initialized.

This message was sent by Atlassian JIRA

View raw message