hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9956) use BigDecimal.valueOf instead of new in TestFileDump
Date Fri, 13 Mar 2015 20:13:38 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361033#comment-14361033
] 

Hive QA commented on HIVE-9956:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12704375/HIVE-9956.1.patch

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 7764 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby3_map_multi_distinct
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3035/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3035/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3035/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12704375 - PreCommit-HIVE-TRUNK-Build

> use BigDecimal.valueOf instead of new in TestFileDump
> -----------------------------------------------------
>
>                 Key: HIVE-9956
>                 URL: https://issues.apache.org/jira/browse/HIVE-9956
>             Project: Hive
>          Issue Type: Bug
>          Components: File Formats
>            Reporter: Alexander Pivovarov
>            Assignee: Alexander Pivovarov
>            Priority: Minor
>         Attachments: HIVE-9956.1.patch
>
>
> TestFileDump builds data row where one of the column is BigDecimal
> The test adds value 2.2222
> There are 2 ways to create BigDecimal object.
> 1. use new
> 2. use valueOf
> in this particular case 
> 1. "new" will create 2.222199999999999953
> 2. valueOf will use the canonical String representation and the result will be 2.2222
> Probably we should use valueOf to create BigDecimal object
> TestTimestampWritable and TestHCatStores use valueOf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message