hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Pivovarov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-9956) use BigDecimal.valueOf instead of new in TestFileDump
Date Fri, 13 Mar 2015 06:42:38 GMT

     [ https://issues.apache.org/jira/browse/HIVE-9956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alexander Pivovarov updated HIVE-9956:
--------------------------------------
    Attachment: HIVE-9956.1.patch

patch #1

> use BigDecimal.valueOf instead of new in TestFileDump
> -----------------------------------------------------
>
>                 Key: HIVE-9956
>                 URL: https://issues.apache.org/jira/browse/HIVE-9956
>             Project: Hive
>          Issue Type: Bug
>          Components: File Formats
>            Reporter: Alexander Pivovarov
>            Assignee: Alexander Pivovarov
>            Priority: Minor
>         Attachments: HIVE-9956.1.patch
>
>
> TestFileDump builds data row where one of the column is BigDecimal
> The test adds value 2.2222
> There are 2 ways to create BigDecimal object.
> 1. use new
> 2. use valueOf
> in this particular case 
> 1. "new" will create 2.222199999999999953
> 2. valueOf will use the canonical String representation and the result will be 2.2222
> Probably we should use valueOf to create BigDecimal object
> TestTimestampWritable and TestHCatStores use valueOf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message