hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9766) Add JavaConstantXXXObjectInspector
Date Tue, 24 Mar 2015 17:57:52 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378268#comment-14378268
] 

Jason Dere commented on HIVE-9766:
----------------------------------

I think all of the getWritableConstantValue() methods need a if(value == null) { return null;
}
Otherwise you risk NPE when it tries to create the writable value to return.

> Add JavaConstantXXXObjectInspector
> ----------------------------------
>
>                 Key: HIVE-9766
>                 URL: https://issues.apache.org/jira/browse/HIVE-9766
>             Project: Hive
>          Issue Type: Improvement
>          Components: Serializers/Deserializers
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>         Attachments: HIVE-9766.1.patch, HIVE-9766.2.patch
>
>
> Need JavaConstantXXXObjectInspector when implementing PIG-3294. There are two approaches:
> 1. Add those classes in Pig. However, most construct of the base class JavaXXXObjectInspector
is default scope, need to change them to protected
> 2. Add those classes in Hive
> Approach 2 should be better since those classes might be useful to Hive as well. Attach
a patch to provide them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message