hive-gitbox mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hive] abstractdog commented on a change in pull request #2099: HIVE-24761: Support vectorization for bounded windows in PTF
Date Mon, 10 May 2021 11:10:16 GMT

abstractdog commented on a change in pull request #2099:
URL: https://github.com/apache/hive/pull/2099#discussion_r629269903



##########
File path: ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt
##########
@@ -34,20 +34,17 @@ public class <ClassName> extends VectorExpression {
 
   private static final long serialVersionUID = 1L;
 
-  private final int colNum1;
   private final int colNum2;

Review comment:
       a) regarding input columns, a simple solution is could be https://github.com/apache/hive/pull/2099/commits/5db4c60aec34df291a1d1d85be319c865adcd1ad
   created convenience constructors, subclasses should be refactored accordingly now with
care
   
   b) I was also wondering about having an array of inputcolumns as:
   ```
   public int[] inputColumnNums = new int[] { -1, -1, -1 };
   ```
   this could be more general, more easily extendable, and needs a bit more refactoring (every
existing occurrence of inputColumn should become inputColumnNums[0])
   
   so regarding the class naming, we won't change anything (to unary, binary, ...) just use
the proper constructor in subclasses




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Mime
View raw message