hive-gitbox mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hive] ayushtkn commented on a change in pull request #2043: HIVE-24852. Add support for Snapshots during external table replication.
Date Tue, 04 May 2021 18:55:11 GMT

ayushtkn commented on a change in pull request #2043:
URL: https://github.com/apache/hive/pull/2043#discussion_r626027229



##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/ReplicationTestUtils.java
##########
@@ -544,12 +544,13 @@ public static void assertExternalFileList(List<String> expected,
String dumploca
     Set<String> tableNames = new HashSet<>();
     for (String line = reader.readLine(); line != null; line = reader.readLine()) {
       String[] components = line.split(DirCopyWork.URI_SEPARATOR);
-      Assert.assertEquals("The file should have sourcelocation#targetlocation#tblName",
-              3, components.length);
+      Assert.assertEquals("The file should have sourcelocation#targetlocation#tblName#copymode",
5,

Review comment:
       For all external tables, Others we don't need. External Tables: Either will follow
snapshot based repl(INITIAL/DIFF) or not(FALLBACK)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Mime
View raw message