hive-gitbox mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hive] abstractdog commented on a change in pull request #2225: HIVE-25061: PTF: Improve BoundaryCache
Date Mon, 03 May 2021 09:39:33 GMT

abstractdog commented on a change in pull request #2225:
URL: https://github.com/apache/hive/pull/2225#discussion_r624975433



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/BasePartitionEvaluator.java
##########
@@ -218,6 +220,9 @@ public BasePartitionEvaluator(
     this.outputOI = outputOI;
     this.nullsLast = nullsLast;
     this.isCountEvaluator = wrappedEvaluator instanceof GenericUDAFCount.GenericUDAFCountEvaluator;
+    // use a periodic logger which ignores very small partitions
+    this.stopwatch = new PeriodicLoggerWithStopwatch(

Review comment:
       right, I'm also thinking about completely removing this logger from here, and add it
in a separate ticket, because it can be also used in FileSinkOperator
   created HIVE-25087




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Mime
View raw message