hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashutoshc commented on a change in pull request #552: Hive 21279
Date Wed, 27 Feb 2019 21:58:47 GMT
ashutoshc commented on a change in pull request #552: Hive 21279
URL: https://github.com/apache/hive/pull/552#discussion_r260962107
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
 ##########
 @@ -1511,9 +1525,10 @@ public static void mvFileToFinalPath(Path specPath, Configuration
hconf,
     //      Deduplicate and keep a list of files
     //      Pass on the list of files to conf (to be used later by fetch operator)
     //    if true:
-    //      Rename tmpPath to a new directory name
-    //      Remove duplicates
-    //      Rename/move the new directory to specPath
+    //       1) Rename tmpPath to a new directory name to prevent additional files
 
 Review comment:
   can we also restore the comment which already existed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message