hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sankarh commented on a change in pull request #541: HIVE-21197 : Hive Replication can add duplicate data during migration to a target with hive.strict.managed.tables enabled
Date Fri, 22 Feb 2019 09:13:29 GMT
sankarh commented on a change in pull request #541: HIVE-21197 : Hive Replication can add duplicate
data during migration to a target with hive.strict.managed.tables enabled
URL: https://github.com/apache/hive/pull/541#discussion_r259254156
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java
 ##########
 @@ -71,6 +74,20 @@ public void init(AtomicBoolean stop, AtomicBoolean looped) throws Exception
{
     }
   }
 
+  @Override boolean replIsCompactionDisabledForDatabase(String dbName) throws TException
{
+    try {
+      Database database = rs.getDatabase(getDefaultCatalog(conf), dbName);
+      if (database != null) {
+        return !ReplUtils.isFirstIncDone(database.getParameters());
+      }
+      LOG.info("Unable to find database " + dbName);
 
 Review comment:
   Why 2 different flows for No database case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message