hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From denys kuzmenko via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active
Date Mon, 15 Oct 2018 19:21:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69022/
-----------------------------------------------------------

(Updated Oct. 15, 2018, 7:21 p.m.)


Review request for hive, Sahil Takiar and Adam Szita.


Changes
-------

updated the patch file.


Summary (updated)
-----------------

HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when
there is no active


Bugs: HIVE-20737
    https://issues.apache.org/jira/browse/HIVE-20737


Repository: hive-git


Description (updated)
-------

1. Local SparkContext is shared between user sessions and should be closed only when there
is no active. 
2. Possible race condition in SparkSession.open() in case when user queries run in parallel
within the same session.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java 72ff53e3bd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java bb50129518

  ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestLocalHiveSparkClient.java PRE-CREATION



Diff: https://reviews.apache.org/r/69022/diff/2/


Testing
-------

Added TestLocalHiveSparkClient test


File Attachments
----------------

HIVE-20737.7.patch
  https://reviews.apache.org/media/uploaded/files/2018/10/15/9cf8a2b3-9ec1-4316-81d0-3cd124b1a9fd__HIVE-20737.7.patch


Thanks,

denys kuzmenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message