From dev-return-146436-archive-asf-public=cust-asf.ponee.io@hive.apache.org Thu Feb 22 17:45:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A4CE218064E for ; Thu, 22 Feb 2018 17:45:52 +0100 (CET) Received: (qmail 28252 invoked by uid 500); 22 Feb 2018 16:45:51 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 28236 invoked by uid 99); 22 Feb 2018 16:45:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Feb 2018 16:45:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 44ADCC0145; Thu, 22 Feb 2018 16:45:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.892 X-Spam-Level: * X-Spam-Status: No, score=1.892 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id I8tIENJGk9fg; Thu, 22 Feb 2018 16:45:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C87BA5F1B3; Thu, 22 Feb 2018 16:45:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5EE8AE00B8; Thu, 22 Feb 2018 16:45:47 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 81E4BC4015D; Thu, 22 Feb 2018 16:45:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5538302985304408616==" MIME-Version: 1.0 Subject: Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration From: Sahil Takiar To: Marta Kuczora , Adam Szita , Sahil Takiar Cc: Peter Vary , hive Date: Thu, 22 Feb 2018 16:45:45 -0000 Message-ID: <20180222164545.16916.57537@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sahil Takiar X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65753/ X-Sender: Sahil Takiar References: <20180222122532.16917.43870@reviews-vm2.apache.org> In-Reply-To: <20180222122532.16917.43870@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreClientTest.java Reply-To: Sahil Takiar X-ReviewRequest-Repository: hive-git --===============5538302985304408616== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/#review198121 ----------------------------------------------------------- so just to clarify, the creation of metastore instances is moving from the individual contructors to a `BeforeClass` method? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreClientTest.java Lines 18 (patched) random thought, should be move these into a package like `o.a.h.hive.metastore.client.api`? or does it need to be in this package? not a blocker standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreClientTest.java Lines 60 (patched) can this be `private` standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreClientTest.java Lines 62 (patched) why are there multiple metastores that need to be started? is it for the embedded and remote metastore? since its a Parameterized test does BeforeClass / AfterClass not get run separately for each one? - Sahil Takiar On Feb. 22, 2018, 12:25 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65753/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 12:25 p.m.) > > > Review request for hive, Marta Kuczora, Sahil Takiar, and Adam Szita. > > > Bugs: HIVE-18771 > https://issues.apache.org/jira/browse/HIVE-18771 > > > Repository: hive-git > > > Description > ------- > > For every class only 1 metastore is initialized for every configuration > Refactored tests, so it will have a common parent class which handles initializations (Thanks Sahil for proposing it previously. You were right after all :) ) > > > Diffs > ----- > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreClientTest.java PRE-CREATION > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactoryForTests.java e723f60 > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java d25b81e > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java f483ca8 > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java 919ba78 > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java 31b3154 > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java cfec569 > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java c1c1c61 > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java e550bca > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java 3a06aec > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java 1974399 > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java 1db7adc > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java 2c7f3fb > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetTableMeta.java 7ede38f > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java 93bcd19 > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java dbcc57e > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetExists.java 0af873b > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesList.java 15bd6c6 > > > Diff: https://reviews.apache.org/r/65753/diff/1/ > > > Testing > ------- > > Run the affected tests > > > Thanks, > > Peter Vary > > --===============5538302985304408616==--