From dev-return-146232-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Feb 9 21:03:39 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id C2F09180654 for ; Fri, 9 Feb 2018 21:03:39 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B2845160C5E; Fri, 9 Feb 2018 20:03:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CE262160C3C for ; Fri, 9 Feb 2018 21:03:38 +0100 (CET) Received: (qmail 76710 invoked by uid 500); 9 Feb 2018 20:03:37 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 76695 invoked by uid 99); 9 Feb 2018 20:03:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Feb 2018 20:03:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 622CFC00E0; Fri, 9 Feb 2018 20:03:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.691 X-Spam-Level: X-Spam-Status: No, score=0.691 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id d2O7Gs9YcKCK; Fri, 9 Feb 2018 20:03:33 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8E35B5F27D; Fri, 9 Feb 2018 20:03:33 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1D7CFE002F; Fri, 9 Feb 2018 20:03:33 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E1620C40017; Fri, 9 Feb 2018 20:03:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1543791332342788323==" MIME-Version: 1.0 Subject: Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables From: Sergey Shelukhin To: Eugene Koifman Cc: Sergey Shelukhin , hive Date: Fri, 09 Feb 2018 20:03:32 -0000 Message-ID: <20180209200332.47223.16984@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sergey Shelukhin X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65413/ X-Sender: Sergey Shelukhin References: <20180203012648.12686.32357@reviews-vm2.apache.org> In-Reply-To: <20180203012648.12686.32357@reviews-vm2.apache.org> Reply-To: Sergey Shelukhin X-ReviewRequest-Repository: hive-git --===============1543791332342788323== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 3, 2018, 1:26 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > This seems to change the logic. isAcidTable() used to mean full acid, but now it less than that... > > Sergey Shelukhin wrote: > Responded on IM :) > > Eugene Koifman wrote: > I don't see it in IM. Why is this done? > > Eugene Koifman wrote: > I'd like an answer This is the dup of the other comment, the change was already undone in the last revision - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/#review196778 ----------------------------------------------------------- On Feb. 9, 2018, 1:52 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65413/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2018, 1:52 a.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > . > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649 > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7 > hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446 > hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2 > hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7 > hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9 > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a > ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651 > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551 > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc > ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6 > ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005 > ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b > ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c > ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9 > > > Diff: https://reviews.apache.org/r/65413/diff/5/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > > --===============1543791332342788323==--