From dev-return-146169-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Feb 7 16:35:47 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 285B618065B for ; Wed, 7 Feb 2018 16:35:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 17A0D160C5B; Wed, 7 Feb 2018 15:35:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5C8C7160C3C for ; Wed, 7 Feb 2018 16:35:46 +0100 (CET) Received: (qmail 56266 invoked by uid 500); 7 Feb 2018 15:35:45 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 56251 invoked by uid 99); 7 Feb 2018 15:35:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Feb 2018 15:35:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 12C881A0511; Wed, 7 Feb 2018 15:35:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id oJXgSH66YRYo; Wed, 7 Feb 2018 15:35:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 421EA5FAC9; Wed, 7 Feb 2018 15:35:42 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9D494E0047; Wed, 7 Feb 2018 15:35:41 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id AAC29C40471; Wed, 7 Feb 2018 15:35:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3227760829505960366==" MIME-Version: 1.0 Subject: Re: Review Request 65507: HIVE-18580: Create tests to cover exchange partitions From: Marta Kuczora via Review Board To: Peter Vary , Adam Szita Cc: hive , Marta Kuczora Date: Wed, 07 Feb 2018 15:35:39 -0000 Message-ID: <20180207153539.29731.14019@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Marta Kuczora X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65507/ X-Sender: Marta Kuczora References: <20180205180103.45676.2190@reviews-vm2.apache.org> In-Reply-To: <20180205180103.45676.2190@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java Reply-To: Marta Kuczora X-ReviewRequest-Repository: hive-git --===============3227760829505960366== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65507/ ----------------------------------------------------------- (Updated Feb. 7, 2018, 3:35 p.m.) Review request for hive, Peter Vary and Adam Szita. Changes ------- Fixed the review findings. Bugs: HIVE-18580 https://issues.apache.org/jira/browse/HIVE-18580 Repository: hive-git Description ------- The following methods of IMetaStoreClient are covered by this test. - int Partition exchange_partition(Map, String, String, String, String) - List Partition exchange_partition(Map, String, String, String, String) The test covers not just the happy pathes, but the edge cases as well. Diffs (updated) ----- standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java PRE-CREATION Diff: https://reviews.apache.org/r/65507/diff/2/ Changes: https://reviews.apache.org/r/65507/diff/1-2/ Testing ------- Ran the tests Thanks, Marta Kuczora --===============3227760829505960366==--