hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gopal V <go...@hortonworks.com>
Subject Re: Review Request 65431: HIVE-16605 : NOT NULL constraint enforcement
Date Mon, 05 Feb 2018 19:08:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65431/#review196823
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEnforceNotNullConstraint.java
Lines 45 (patched)
<https://reviews.apache.org/r/65431/#comment276660>

    The vectorized expressions is picked up as-is, you need to remove them to prevent vectorization.
    
    FuncAbs is not a replacement for enforce_constraint.
    
    Needs an "explain vectorization detail" qtest to verify.


- Gopal V


On Feb. 4, 2018, 2:36 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65431/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2018, 2:36 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-16605
>     https://issues.apache.org/jira/browse/HIVE-16605
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This patch introduces support for enable NOT NULL constraint enforcement for following
type of statements:
> 
> * INSERT INTO
> * INSERT as SELECT
> * INSERT OVERWRITE
> * UPDATE
> * MERGE
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 99e8457c7b 
>   itests/src/test/resources/testconfiguration.properties fed9394544 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 76e85636d1 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java b1e05dffe9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 372cfad866 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2e24999eb 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 9fcde76d21 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java e3a9e62bdb 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEnforceNotNullConstraint.java
PRE-CREATION 
>   ql/src/test/queries/clientnegative/alter_notnull_constraint_violation.q PRE-CREATION

>   ql/src/test/queries/clientnegative/create_with_constraints_enable.q 59ebb1e9b2 
>   ql/src/test/queries/clientnegative/create_with_constraints_enforced.q  
>   ql/src/test/queries/clientnegative/create_with_fk_constraints_enforced.q PRE-CREATION

>   ql/src/test/queries/clientnegative/create_with_unique_constraints_enforced.q PRE-CREATION

>   ql/src/test/queries/clientnegative/insert_into_acid_notnull.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/insert_into_notnull_constraint.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/insert_multi_into_notnull.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/insert_overwrite_notnull_constraint.q PRE-CREATION

>   ql/src/test/queries/clientnegative/merge_constraint_notnull.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/update_notnull_constraint.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/enforce_constraint_notnull.q PRE-CREATION 
>   ql/src/test/results/clientnegative/alter_notnull_constraint_violation.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/create_with_constraints_enable.q.out  
>   ql/src/test/results/clientnegative/create_with_constraints_enforced.q.out  
>   ql/src/test/results/clientnegative/create_with_fk_constraints_enforced.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/insert_into_acid_notnull.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/insert_into_notnull_constraint.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/insert_multi_into_notnull.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/insert_overwrite_notnull_constraint.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/merge_constraint_notnull.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/update_notnull_constraint.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/show_functions.q.out 43e4a5de39 
> 
> 
> Diff: https://reviews.apache.org/r/65431/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message