From dev-return-145985-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Jan 31 06:20:39 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 97D3718061A for ; Wed, 31 Jan 2018 06:20:39 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 87567160C54; Wed, 31 Jan 2018 05:20:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CDFBB160C53 for ; Wed, 31 Jan 2018 06:20:38 +0100 (CET) Received: (qmail 13118 invoked by uid 500); 31 Jan 2018 05:20:37 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 13088 invoked by uid 99); 31 Jan 2018 05:20:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 05:20:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 623B0C00CD; Wed, 31 Jan 2018 05:20:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.44 X-Spam-Level: * X-Spam-Status: No, score=1.44 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 2czI-UyNbD3I; Wed, 31 Jan 2018 05:20:34 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 291A15F19D; Wed, 31 Jan 2018 05:20:34 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03768E00B0; Wed, 31 Jan 2018 05:20:33 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3748BC4025B; Wed, 31 Jan 2018 05:20:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8331470407039568267==" MIME-Version: 1.0 Subject: Re: Review Request 65296: HIVE-18259 From: Ashutosh Chauhan To: Ashutosh Chauhan Cc: hive , =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= Date: Wed, 31 Jan 2018 05:20:31 -0000 Message-ID: <20180131052031.30294.32683@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ashutosh Chauhan X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65296/ X-Sender: Ashutosh Chauhan X-ReviewBoard-ShipIt: 1 References: <20180123205623.50413.16675@reviews-vm2.apache.org> In-Reply-To: <20180123205623.50413.16675@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsCacheCleanerTask.java X-ReviewBoard-Diff-For: standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMaterializationsCacheCleaner.java Reply-To: Ashutosh Chauhan X-ReviewRequest-Repository: hive-git --===============8331470407039568267== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65296/#review196551 ----------------------------------------------------------- Fix it, then Ship it! =1 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsCacheCleanerTask.java Lines 54 (patched) LOG.info - Ashutosh Chauhan On Jan. 23, 2018, 8:56 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65296/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2018, 8:56 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-18259 > https://issues.apache.org/jira/browse/HIVE-18259 > > > Repository: hive-git > > > Description > ------- > > HIVE-18259 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 05c2acd0ff40e018bf41f077c47599ea6f9ef7df > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 23983d85b33d71c81ea255cbcea7aeca86017024 > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsCacheCleanerTask.java PRE-CREATION > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java de912d5630ec04f0d0f7c1ac059d6acec92e9bcc > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java 3c8d005e3cb55739c91c340d2718850cb00747de > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMaterializationsCacheCleaner.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/65296/diff/1/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > > --===============8331470407039568267==--